Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

use current and LTS Node.js in CI #381

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Conversation

Trott
Copy link
Contributor

@Trott Trott commented Jul 10, 2018

Update .travis.yml to use latest Node.js and an LTS release for
testing. Currently, Node.js 4.x is hard-coded. Node.js 4.x is currently
unsupported by the Node.js project. There will be no more 4.x releases.
Any security vulnerabilities or other bugs currently in 4.x will be there
forever.

Update `.travis.yml` to use latest Node.js and an LTS release for
testing. Currently, Node.js 4.x is hard-coded. Node.js 4.x is currently
unsupported by the Node.js project. There will be no more 4.x releases.
Any security vulnerabilities or other bugs currently in 4.x will be there
forever.
@Trott
Copy link
Contributor Author

Trott commented Jul 10, 2018

I guess since this since builds on Node.js 10, it seems likely that it is blocked until #380 or something similar is merged.

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zeke zeke merged commit 718169f into electron:master Jul 12, 2018
@zeke
Copy link
Contributor

zeke commented Jul 12, 2018

Thanks @Trott

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants