This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Use update-electron-app #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zeke i think the test failures are a larger problem...i'm planning on looking at and updating them as needed sometime soon |
Merged
|
@codebytere this is fixed now. Should be ready to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old hand-rolled updater code and replaces it with the new update-electron-app module which talks to update.electronjs.org. The electron-log module used here coalesces logs from main and renderer processes into a single file, which should make debugging easier if needed.
Once we've landed this and confirmed that it works (we'll have to do two releases to do so) we can decommission the old one-off update service we built for this demo app. 👻
cc @haacked