Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

update dependencies #266

Merged
merged 2 commits into from
Sep 28, 2016
Merged

update dependencies #266

merged 2 commits into from
Sep 28, 2016

Conversation

zeke
Copy link
Contributor

@zeke zeke commented Sep 28, 2016

When running npm install today, I see a lot of deprecation notices:

screen shot 2016-09-28 at 11 46 47 am

I used npm-check to update outdated dependencies, and now most of those warnings are gone.

@zeke
Copy link
Contributor Author

zeke commented Sep 28, 2016

👀 @kevinsawicki @haacked

Once this lands I will build a new release.

"snazzy": "^5.0.0",
"spectron": "~3.2.6",
"standard": "^6.0.8"
"spectron": "^3.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minor version of spectron tracks the minor version of Electron, so 3.4 targets electron 1.4, and the ~ should be used instead of the ^ to enforce this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Fixed.

@zeke zeke merged commit a9ae2a7 into master Sep 28, 2016
@zeke zeke deleted the upkeep branch September 28, 2016 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants