-
Notifications
You must be signed in to change notification settings - Fork 107
feat: add configurable logLevel to install options
#283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4ffb8ee
feat: add configurable logger with `quiet` mode and `ignoreLogs` support
hitarth-gg b48f925
docs: update README.md
hitarth-gg 232a734
fix: types
hitarth-gg 08b52a0
docs: add examples for install options
hitarth-gg 9f71fd8
chore: use `logLevel` instead
hitarth-gg 0ef983d
docs: update `install` options in README.md
hitarth-gg cea7e8e
docs: minor change
hitarth-gg 16c57a8
Merge branch 'main' into feat/quiet-install
dsanders11 4b26908
Merge branch 'main' into feat/quiet-install
hitarth-gg 4955558
chore: use enums
hitarth-gg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import type { LogLevelString } from '../types/shared'; | ||
| import { LogLevel } from '../types/shared'; | ||
|
|
||
| class Logger { | ||
| private currentLogLevel = LogLevel.debug; | ||
|
|
||
| setLogLevel(level: LogLevelString) { | ||
| if (LogLevel[level] === undefined) { | ||
| console.error(`Invalid log level: ${level}`); | ||
| return; | ||
| } | ||
|
|
||
| if (LogLevel[level] === this.currentLogLevel) return; // no change | ||
|
|
||
| this.currentLogLevel = LogLevel[level]; | ||
| } | ||
|
|
||
| private log(level: LogLevel, ...args: any[]) { | ||
| if (this.currentLogLevel === LogLevel.none) return; | ||
| if (level < this.currentLogLevel) return; | ||
|
|
||
| switch (level) { | ||
| case LogLevel.debug: | ||
| console.debug(...args); | ||
| break; | ||
| case LogLevel.info: | ||
| console.log(...args); | ||
| break; | ||
| case LogLevel.warn: | ||
| console.warn(...args); | ||
| break; | ||
| case LogLevel.error: | ||
| console.error(...args); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| debug(...args: any[]) { | ||
| this.log(LogLevel.debug, ...args); | ||
| } | ||
| info(...args: any[]) { | ||
| this.log(LogLevel.info, ...args); | ||
| } | ||
| warn(...args: any[]) { | ||
| this.log(LogLevel.warn, ...args); | ||
| } | ||
| error(...args: any[]) { | ||
| this.log(LogLevel.error, ...args); | ||
| } | ||
| } | ||
|
|
||
| export const logger = new Logger(); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @erickzhao about a
logLeveloption. Then these two examples could beI'm partial to the idea of the
quietoption as a shorthand though. Open to either keeping it or removing it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my head it'd look more like a sliding scale:
since it'd be unlikely that you would want to specifically ignore non-contiguous log levels (e.g. ignoring
erroranddebugbut notinfoandwarn).