Accessible Color Warnings #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also updates the CONTRIBUTING doc to explain the contrast requirements and link to a site that makes it easy to pick accessible colors. Also broke the doc up a bit with more headings so we can more easily deep-link to sections in the doc. |
zeke
added a commit
that referenced
this pull request
Oct 20, 2017
* set color overrides for GPMDP * verify that human-provided colors are accessible * update contributing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pick-a-good-color module will always pick an accessible color, but sometimes the color just doesn't look quite right.
To work around this, #325 enabled app developers to choose their own colors. This PR is a followup that ensures sure the human-provided colors are in fact accessible according to the WCAG guidelines..
When a color's contrast ratio is not high enough, this kind of error is produced:
cc @MarshallOfSound. I took the liberty of adding custom colors for GPMDP as a test case, based on the icon and the website.
cc @codebytere