fix: disable broken app and add safeguards #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh.? What needs to be done here? |
@snaildos seems like CI indicates that the icon you provided isn't actually a PNG. |
My God. Sorry. That's my bad. Will work on a instant fix for this. |
|
Perhaps in a separate PR, a PR check should be added to make sure that any new icons are actually valid PNGs? |
|
SnailFM should be resolved on this PR, #1860 You can maybe really moved the disabled tag of your PR since no need because I just updated the app with a new PR. |
codebytere
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1856
I found out that the SnailFM app was the culprit here due to an error processing the PNG file. I've disabled it and prevented all disabled apps from being processed in the build scripts.
cc @snaildos