Skip to content

Conversation

@ckerr
Copy link
Member

@ckerr ckerr commented Jun 30, 2019

Fixes #1068.

Adds a test to confirm that all URLs in new apps' yml files are https or sftp.

As with some other tests, here we 'grandfather' in older apps that are already in the repo but which don't follow this requirement.

The new test's warnings look like this:

  153) human-submitted app data
       zoommy
         zoommy.yml
           should use ssl links:
     AssertionError: http://zoommyapp.com/: expected 'http:' to be one of [ 'https:', 'sftp:' ]
      at /home/charles/src/electron/apps/apps/test/human-data.js:103:65
      at Array.forEach (<anonymous>)
      at Context.<anonymous> (test/human-data.js:103:18)
      at processImmediate (internal/timers.js:439:21)

CC @MarshallOfSound

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be more efficient and uniform to simply update the deviant links, perhaps?

@ckerr
Copy link
Member Author

ckerr commented Jul 2, 2019

Instead of grandfathering, you mean? Several of the existing links don't work with https.

Interesting idea about winnowing down the list, though. We could fix anything that can be shifted to https.

@ckerr ckerr merged commit 00b11f8 into master Jul 2, 2019
@ckerr ckerr deleted the require-ssl branch July 2, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require https for all images and website URLs

3 participants