feat: find broken links #1120
Merged
feat: find broken links #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably best to stop now.
Member
|
Somewhat related --> #1068 |
Contributor
|
@ckerr, |
codebytere
approved these changes
Jul 2, 2019
Member
codebytere
left a comment
codebytere
left a comment
There was a problem hiding this comment.
If at all possible, I'd love to see some tests for individual functions here but i definitely won't block on that!
I've glanced at this twice before now but every time i've come back you've already addressed all the things i was going to comment on so now that i'm doing my final review it's the easiest 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command-line script for finding broken links in the app repository.
Inspired by the handful of recent PRs that remove this or that broken link. This scrapes all of the apps' links and reports on broken ones.