Skip to content

Conversation

@steveostudios
Copy link

Adding Sidekick which can be found at https://sidekick.tv.

@ci-reporter
Copy link

ci-reporter bot commented Apr 22, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of 28c9df6. Here's the output:

npm test
> electron-apps@1.7406.0 test /home/travis/build/electron/apps
> mocha --reporter min test/human-data.js test/colors-spec.js && standard --fix


  14485 passing (3s)
  1 failing

  1) human-submitted app data
       sidekick
         icon
           is between 256px x 256px and 1024px x 1024px:
     AssertionError: expected 144 to be within 256..1024
      at Context.<anonymous> (test/human-data.js:151:42)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the icon size to make CI happy 🔧

Copy link
Contributor

@Sanjit1 Sanjit1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the CI error, and fix icon size

@vhashimotoo
Copy link
Contributor

ping @steveostudios

@vhashimotoo
Copy link
Contributor

Closing due to inactivity. Please open new PR if to add your application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants