chore: ci:validate, ci:test:fetch-cache simplification, and code cleanup

[mmaietta]

This pull request includes a mix of workflow, dependency, code style, and minor refactoring updates across the repository. The main goals are to streamline CI workflows, clean up dependencies, improve TypeScript and ESLint configurations, and enhance code clarity and maintainability.

CI/CD Workflow Improvements:

• Replaces the custom shell script for restoring the Vitest smart cache in .github/actions/pretest/action.yml with a single pnpm ci:test:fetch-cache command, simplifying cache restoration logic.
• Renames the shard-plan job to validate-and-shard in .github/workflows/test.yaml and adds new steps to validate and lint files before outputting the shard plan, ensuring code quality checks run in CI. [1] [2]
• Simplifies the cache merging step in the test workflow by updating the Merge cache files command to just pnpm ci:test:merge-cache, removing explicit artifact and output arguments.

Dependency and Configuration Updates:

• Removes the unused @types/fs-extra dependency and adds fs-extra as a devDependency in package.json for better dependency hygiene. [1] [2]
• Updates scripts/checkDeps.js to account for dynamic imports (e.g., @electron/universal) and adjusts the known unused/missed dependencies lists for more accurate dependency checks. [1] [2] [3]

ESLint and TypeScript Improvements:

• Adds a specific ESLint override in eslint.config.mjs to disable the @typescript-eslint/unbound-method rule for test files that use Vitest spies/mocks, reducing unnecessary lint errors.
• Removes unnecessary ESLint disable comments and improves code formatting for better readability in several TypeScript files. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Code Refactoring and Minor Fixes:

• Refactors conditional statements for clarity and consistency (e.g., in MacTargetHelper.getPlatformTypeFromTarget, AWS credentials parsing, and S3 header construction). [1] [2] [3]
• Updates test assertions to use vi.mocked(log) for improved mocking and type safety in test/src/cliTest.ts. [1] [2] [3] [4] [5] [6]
• Minor parameter and import cleanups (e.g., removing unused imports, renaming unused parameters with _, and updating type usage). [1] [2] [3]

These changes collectively improve the reliability, maintainability, and clarity of the codebase and CI/CD pipeline.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2d0189d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
app-builder-lib	Patch
electron-publish	Patch
dmg-builder	Patch
electron-builder-squirrel-windows	Patch
electron-builder	Patch
electron-forge-maker-appimage	Patch
electron-forge-maker-nsis-web	Patch
electron-forge-maker-nsis	Patch
electron-forge-maker-snap	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR