Skip to content

Fix/validate tests - #9837

Closed
regnete wants to merge 5 commits into
electron-userland:masterfrom
sitewaerts:fix/validation
Closed

Fix/validate tests#9837
regnete wants to merge 5 commits into
electron-userland:masterfrom
sitewaerts:fix/validation

Conversation

@regnete

@regnete regnete commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

As described in #9836 the validation fails.
This PR fixes all the underlying issues.
After applying the PR validation succeeds again.

regnete added 4 commits June 5, 2026 14:51
@regnete
fix: update dependencies
edeedfe 
add devDependency fs-extra
remove dependency @types/fs-extra
update @eslint/eslintrc version
update eslint-plugin-prettier version
update packageManager version

fixes electron-userland#9836
@regnete
fix: handle well known (dev)dependencies
eb6940a 
ignore missing usage of @electron/universal in app-builder-lib
ignore missing usage of is-ci and vitest in electron-builder

fixes electron-userland#9836
@regnete
fix: remove eslint errors and warnings
ffa76fd 
remove eslint errors and warnings caused by eslint.config.mjs

fixes electron-userland#9836
@regnete
fix: remove eslint errors and warnings
8175d12 
remove eslint errors and warnings caused by eslint.config.mjs

fixes electron-userland#9836
@changeset-bot

changeset-bot Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0c3f350

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
electron-publish Patch
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security

socket-security Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Added@​eslint/​eslintrc@​3.3.59910010084100
Addedeslint-plugin-prettier@​5.5.610010010093100

View full report

@mmaietta

mmaietta commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Can you please split this up into isolated PRs?

  • production eslint fixes (packages/*)
  • test/* changes

Please do not make changes to the package.json versions, lockfile, or packageManager field. I can tackle those from my side.

@regnete

regnete commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the contribution! Can you please split this up into isolated PRs?

  • production eslint fixes (packages/*)
  • test/* changes

Please do not make changes to the package.json versions, lockfile, or packageManager field. I can tackle those from my side.

Sorry. I don't know how to accomplish this.

@regnete

regnete commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the contribution! Can you please split this up into isolated PRs?

  • production eslint fixes (packages/*)
  • test/* changes

Please do not make changes to the package.json versions, lockfile, or packageManager field. I can tackle those from my side.

Sorry. I don't know how to accomplish this.

Working on it now.

@regnete regnete changed the title Fix/validation Fix/validate tests Jun 5, 2026
@regnete regnete closed this Jun 5, 2026
@regnete

regnete commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@regnete @mmaietta