fix: ensure correct dependency graph extraction order and yarn berry _dependencies support #9439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_dependencies support - Change npm dependency graph extraction from parallel to sequential processing to ensure consistent ordering - Add _dependencies field check in yarn berry isProdDependency for proper production dependency detection 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 02ff806 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This pull request makes two improvements to dependency graph extraction for Node.js module collectors:
Summary:
This PR refactors the npm dependency graph extraction logic to ensure sequential, predictable processing order and extends Yarn Berry's production dependency detection to handle all dependency field types.
Key Changes:
- Refactored
extractProductionDependencyGraphin npm collector from a parallel promise pattern to a sequential loop, preventing potential race conditions when processing shared state - Added
_dependenciesanddependenciesfield checks to Yarn Berry'sisProdDependencymethod for comprehensive production dependency detection
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/app-builder-lib/src/node-module-collector/npmNodeModulesCollector.ts | Simplified dependency extraction loop to sequential processing, improving code clarity and preventing race conditions on shared productionGraph state |
| packages/app-builder-lib/src/node-module-collector/yarnBerryNodeModulesCollector.ts | Extended production dependency detection to check _dependencies, dependencies, and optionalDependencies fields for better Yarn Berry compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mmaietta
reviewed
Dec 10, 2025
packages/app-builder-lib/src/node-module-collector/npmNodeModulesCollector.ts
Outdated
Show resolved
Hide resolved
packages/app-builder-lib/src/node-module-collector/yarnBerryNodeModulesCollector.ts
Show resolved
Hide resolved
…ector Add early check for resolvedDeps existence and use for...in loop instead of Object.entries() for better performance. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mmaietta
approved these changes
Dec 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9394 (comment)
🤖 Generated with Claude Code