-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: support Icon Composer icons for macOS #9279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: support Icon Composer icons for macOS #9279
Conversation
🦋 Changeset detectedLatest commit: 2f9afb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
would this support shipping both a |
@Kilian Do you know if those are separate "fields" perceived by mac? e.g., if we package both an I haven't gotten around to updating my mac to Tahoe yet as I'm afraid it'll brick my current dev environment while I'm mid-project. This is indeed on the todo list though |
@mmaietta @Kilian I have tested on macOS Sequoia and with both the Update 1: ![]() The plist property seems to be available since macOS 10.13+, which should mean that the Liquid Glass icon will be visible since that macOS version. Update 2: Tested with macOS Monterey and confirmed that it does show there. ![]() |
Thank you @iamEvanYT ! In this case then, I'd like to refactor this PR to instead leverage the Is there a minimum xcode or macos version required for supporting this CLI tool? Wondering if we need to throw a more descriptive error if the tool command doesn't exist |
@mmaietta I did a few commits a few days ago to change to the |
This is looking solid! Any chance we can add a |
@mmaietta There, the tests passed on my computer, so it should theoretically pass on the CI. However, it may not pass as it still uses the old Xcode SDK and not Xcode 26. In that case, we might have to change the CI runner from Edit: Huh, it seems like the I've added a commit that runs the macIconTests on |
I took a look at Thank you for your great work on this PR and I appreciate your flexibility in working through these iterations |
FYI, this LGTM, but I need to fix the core |
closes #9254
closes #9278
This PR updates the "icon" property to the electron-builder configuration which adds support for icons made with Icon Composer (
.icon
format).On building, it will create an
Assets.car
with the icon which will be bundled inside the app's Resources folder.