-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(updater): don't throw when determining which package manager to use #9113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+743
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: edb5b72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deb: Search for dpkg first RPM: Search for zypper first as safest installation method. Add `--nogpgcheck` to dnf and yum. fallback to `rpm`
…c flows for each package manager
# Conflicts: # .github/workflows/test.yaml # package.json # test/src/updater/Dockerfile-archlinux # test/src/updater/Dockerfile-rpm # test/src/updater/linuxUpdaterTest.ts # test/src/updater/test-specific-platforms.sh
…ing or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This was referenced May 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9099
sudo
for CLI env) and running without elevation when process is already rootcommand -v
instead ofwhich
to determine which package manager and sudo to userpm
yum
andapt
for RpmUpdaterapt
support for DebUpdaterfedora
,bookworm
, andarchlinux
to test individual installation flows (as root user, but at least we have better coverage than before)