feat: Allow users to pass a custom headers URL #8785
Conversation
🦋 Changeset detectedLatest commit: d66003b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lamawithonel
force-pushed
the
feature/add_electron_headers_disturl
branch
6 times, most recently
from
b2da338 to
3f101e2
Compare
|
@lamawithonel can you try setting your mirror value to env var |
|
Honestly, I'd love to just migrate the entire logic to I'll prep a PR with the changes so that we have a draft PR for the v27 (which will be timed with |
|
Changing the version here doesn't work quite how I thought it would. There is still a line in @electron/rebuild that fails when it's changed. The calling code from my "scripts": {
"ci:install": "ELECTRON_SKIP_BINARY_DOWNLOAD=1 npm install",
"postinstall": "electron-builder install-app-deps", |
Prior to this `packages/app-builder-lib/src/util/yarn.ts` hard-coded the Electron headers `disturl` with no option to configure it for a local mirror. This commit changes it to try the environment variable `npm_config_electron_headers_disturl` before using the hard-coded value. This lets users set the variable `electron_headers_disturl=https://example.com/custom-headers-mirror` to use a local mirror.
This reverts commit 3f101e2.
lamawithonel
force-pushed
the
feature/add_electron_headers_disturl
branch
from
3f101e2 to
73f5652
Compare
Prior to this
packages/app-builder-lib/src/util/yarn.tshard-coded the Electron headersdisturlwith no option to configure it for a local mirror. This commit changes it to try the environment variablenpm_config_electron_headers_disturlbefore using the hard-coded value. This lets users set the variableelectron_headers_disturl=https://example.com/custom-headers-mirrorto use a local mirror.