Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry renaming update file when EBUSY error occurs due to file lock #8437

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

juwonjung-hdj
Copy link
Contributor

This PR addresses the issue reported in #6031.

Problem:
Auto-update occasionally fails when another process (e.g., antivirus scanner) locks the temp update file during the rename operation.

Solution:
Update the logic to retry the rename operation for approximately 30 seconds if the error is EBUSY.

Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: 2ab94eb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 2ab94eb
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66d905bab6ac500007674ba8
😎 Deploy Preview https://deploy-preview-8437--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator

mmaietta commented Sep 4, 2024

Just noticed a changeset file is missing from the PR. Can you please generate one using pnpm generate-changeset when you have a chance?
I tried to directly via the PR since I have the write permissions to PRs, but I received an error that the fork is out of date.

@juwonjung-hdj
Copy link
Contributor Author

juwonjung-hdj commented Sep 5, 2024

Just noticed a changeset file is missing from the PR. Can you please generate one using pnpm generate-changeset when you have a chance? I tried to directly via the PR since I have the write permissions to PRs, but I received an error that the fork is out of date.

I've added a changeset file as a patch bump.

@mmaietta mmaietta merged commit be625e0 into electron-userland:master Sep 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants