Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron-updater,deb): Handle spaces in application artifact name for deb #8400

Merged
merged 6 commits into from
Aug 6, 2024
Merged

fix(electron-updater,deb): Handle spaces in application artifact name for deb #8400

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
044efbb
fix(electron-updater,deb): Fix Linux deb auto updater install command.
Ryan432 Aug 5, 2024
cb111c6
Fix auto update for installerPath having spaces.
Ryan432 Aug 5, 2024
6f83c85
Added comment
Ryan432 Aug 5, 2024
abe596a
Update packages/electron-updater/src/DebUpdater.ts
Ryan432 Aug 6, 2024
353aea2
Fix comment
Ryan432 Aug 6, 2024
2146fd4
Added changeset
Ryan432 Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/electron-updater/src/DebUpdater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@ export class DebUpdater extends BaseUpdater {

protected doInstall(options: InstallOptions): boolean {
const sudo = this.wrapSudo()
// pkexec doesn't want the command to be wrapped in " quotes
const wrapper = /pkexec/i.test(sudo) ? "" : `"`
const cmd = ["dpkg", "-i", options.installerPath, "||", "apt-get", "install", "-f", "-y"]
this.spawnSyncLog(sudo, [`${wrapper}/bin/bash`, "-c", `'${cmd.join(" ")}'${wrapper}`])
const installCommand = `'dpkg -i ${options.installerPath} || apt-get install -f -y'`
Ryan432 marked this conversation as resolved.
Show resolved Hide resolved
this.spawnSyncLog(sudo, ["/bin/bash", "-c", installCommand])
if (options.isForceRunAfter) {
this.app.relaunch()
}
Expand Down
Loading