Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing certificateFile and certificatePassword options description #774

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Conversation

wojtkowiak
Copy link
Contributor

@wojtkowiak wojtkowiak commented Sep 23, 2016

I was just trying to code sign on Windows and spent a moment to find whether it is already supported and how to use it so I allowed myself to update the docs.

@mention-bot
Copy link

@wojtkowiak, thanks for your PR! By analyzing the annotation information on this pull request, we identified @develar, @ha-D and @symbyte to be potential reviewers

@develar
Copy link
Member

develar commented Sep 23, 2016

Please reflect my comment — #548 (comment)

certificateFile is required only and only if you build on mac, otherwise you should use CSC_LINK

certificatePassword is required only and only if you build on mac AND you win cert password is not equals to mac cert password.

@wojtkowiak
Copy link
Contributor Author

Good to know :) Updated, let me know if this way it reflects better the proper way of using it.

@develar
Copy link
Member

develar commented Oct 6, 2016

Thanks. Please edit macOptions.ts/winOptions.ts files in the future.

@develar develar merged commit 956a52d into electron-userland:master Oct 6, 2016
@wojtkowiak wojtkowiak deleted the docsupdate branch October 6, 2016 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants