Skip to content

fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE #6964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2022
Merged

fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE #6964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ad7d88
fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE
geovie Jun 28, 2022
a9a887d
Create cuddly-books-approve.md
mmaietta Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-books-approve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE
3 changes: 1 addition & 2 deletions packages/app-builder-lib/src/targets/nsis/WebInstallerTarget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,9 @@ export class WebInstallerTarget extends NsisTarget {
}

appPackageUrl = computeDownloadUrl(publishConfigs[0], null, packager)

defines.APP_PACKAGE_URL_IS_INCOMLETE = null
}

defines.APP_PACKAGE_URL_IS_INCOMPLETE = null
defines.APP_PACKAGE_URL = appPackageUrl
}

Expand Down
2 changes: 1 addition & 1 deletion packages/app-builder-lib/templates/nsis/include/webPackage.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
StrCpy $packageUrl "${APP_PACKAGE_URL}"
StrCpy $packageArch "${APP_PACKAGE_URL}"

!ifdef APP_PACKAGE_URL_IS_INCOMLETE
!ifdef APP_PACKAGE_URL_IS_INCOMPLETE
!ifdef APP_64_NAME
!ifdef APP_32_NAME
!ifdef APP_ARM64_NAME
Expand Down