-
-
Couldn't load subscription status.
- Fork 1.8k
fix: Merge arrays from same config key. #6841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Meng-Yuan Huang <myh@live.com>
🦋 Changeset detectedLatest commit: ba61d78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@MrMYHuang this PR seems to have caused a bug in the latest version, can you please take a look? The effective electron-builder config shows it duplicated, This doesn't seem to cause an issue with |
I can't reproduce it on Linux and macOS with electron-builder 23.0.9. I tested with extraFiles in both parent config and current config, and each extraFiles has two elements as your example with different "from" values. Please revert this PR as your decision. |
|
OMG, this BREAKING CHANGE messed up all my config inherits. |
Follow up from: #6841 (comment) Filters out duplicate assign's when cascading configs (files, extraFiles, etc.) by converting to Set first
|
I wonder if this could be related to #7021. |
With these changes, electron-builder can merge extraResources from parent config and current conifg. For example:
common.json:
specific.json:
The merged config - dist/builder-effective-config.yaml: