fix(msi): fix broken shortcut icon when using msi target

[erikrz]

fix (msi): broken shortcut icon (#5965)

Add MSI option "iconId", replaces old static "icon.ico" icon identifier.

[changeset-bot]

🦋 Changeset detected

Latest commit: 874ee4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
app-builder-lib	Patch
dmg-builder	Patch
electron-builder-squirrel-windows	Patch
electron-builder	Patch
electron-forge-maker-appimage	Patch
electron-forge-maker-nsis-web	Patch
electron-forge-maker-nsis	Patch
electron-forge-maker-snap	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✔️ Deploy Preview for jolly-roentgen-9c9aba ready!

🔨 Explore the source changes: 874ee4e

🔍 Inspect the deploy log: https://app.netlify.com/sites/jolly-roentgen-9c9aba/deploys/613bde54f5ba80000a072a5b

😎 Browse the preview: https://deploy-preview-6247--jolly-roentgen-9c9aba.netlify.app

[mmaietta]

Is this backward compatible with previous builds? Just want to make sure the icon doesn't break when an update is installed.

[erikrz]

Yes, it does not impact app icons in taskbar, installer and uninstaller.
It only fixes start menu and desktop shortcut icons, which have been broken for a while because we did not comply with how the data is required by Wix.

[mmaietta]

Can you try rebasing this off latest master? I'm not sure why the doc generator is failing.

[hasanatmango]

@erikrz Where we need to add iconId in package.json file ?