Adding 10% on size for temporary dmg used in hdiutil #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @develar I can't see that my code is related to bugs reported by Travis and Circleci |
|
@vladotesanovic I've had the same failings in my PR, which I've updated the snapshots on. I suspect it's just that something has changed w/ one of the libs upstream :) Hopefully we'll both get reviewed soon. |
|
The new release is not published. This issue not be resolved yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon signing and notarization electron-builder is expanding application more than allocated size in method
computeAssetSizewhich is located under:This fix is adding 10% of additional size on temporary dmg. This fix closes #3301 among other tasks which 'no space left on device'.