Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential redirect fix #3168

Closed
wants to merge 2 commits into from
Closed

Conversation

adrianmteo
Copy link

I was having a problem with downloading updates from Github and some other people as well (#2540, #2559, etc.).

I found out that the problem was that the redirect function was not firing when downloading the update, therefore not deleting the Authentication field from the header and sending an invalid key to AWS.

@develar
Copy link
Member

develar commented Jul 25, 2018

Thanks a lot. Proper solution will be get rid of this code — download using common util method and then pass local file to squirrel.mac. I will finally do it tomorrow.

@develar develar closed this Jul 25, 2018
@develar develar reopened this Jul 25, 2018
@develar develar closed this in f966f1a Jul 26, 2018
@develar
Copy link
Member

develar commented Jul 26, 2018

Please try electron-updater 3.1.1

@sostenesapollo
Copy link

I was having a problem with downloading updates from Github and some other people as well (#2540, #2559, etc.).

I found out that the problem was that the redirect function was not firing when downloading the update, therefore not deleting the Authentication field from the header and sending an invalid key to AWS.

How can I use it instead my electron-updater ?

@sostenesapollo
Copy link

Thanks a lot. Proper solution will be get rid of this code — download using common util method and then pass local file to squirrel.mac. I will finally do it tomorrow.

3.1.1

When i executed this ...

loaded configuration file=package.json ("build" field) At least electron-updater 4.0.0 is recommended by current electron-builder version. Please set electron-updater version to "^4.0.0"

@sostenesapollo
Copy link

Someone can help me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants