Description
What would I like
Please consider bumping @electron/rebuild@3.7.0, released Oct 8, 2024, to @electron/rebuild@3.7.1, released Nov 12, 2024 (current latest
), in packages/app-builder-lib
Why it's needed
When I tested an update of electron-builder
in cypress-io/cypress from electron-builder@^25.1.8 to electron-builder@^26.0.12 (current latest
) I was blocked by an nx
error:
lerna notice cli v8.1.9
lerna ERR! The "nx/js/dependencies-and-lockfile" plugin threw an error while creating dependencies: Source project does not exist: npm:@electron/node-gyp@git+https://github.com/electron/node-gyp.git#06b29aafb7708acef8b3669835c8a7857ebc92d2
lerna ERR! Error: Source project does not exist: npm:@electron/node-gyp@git+https://github.com/electron/node-gyp.git#06b29aafb7708acef8b3669835c8a7857ebc92d2
This doesn't make a lot of sense to me, and it could be a lerna / nx / Yarn v1 bug.
cypress-io/cypress already migrated to use @electron/rebuild@3.7.1 and if I downgrade to @electron/rebuild@3.7.0 in cypress-io/cypress then I can update to electron-builder@^26.0.12 without the lerna error that occurs during dependency installation.
I don't really feel comfortable with having to downgrade @electron/rebuild
, especially as I don't understand the root cause behind the problem, so if it would be possible for electron-builder
to update to @electron/rebuild@3.7.1, that would be great!
History
- PR chore(deps): update @electron/rebuild to 3.7.0 #8575 from @doctolivier previously bumped to @electron/rebuild@3.7.0