Unable to copy file for caching: ENOENT

[theboolean]

• Electron-Builder Version: 24.13.3

• Node Version: 18.x

• Electron Version: 31
• Electron Type (current, beta, nightly): current
  Which version of electron-updater are you using (if applicable)? 6.3.4

• Target: macOS

After updating electron-updater from 6.2.0 to 6.3.4 we are getting errors like:
Unable to copy file for caching: ENOENT: no such file or directory, copyfile '/Users/{USER_NAME_REDACTED}/Library/Caches/{APP_NAME_REDACTED}-updater/pending/{APP_NAME_AND_VERSION_REDACTED}-arm64-mac.zip' -> ''
every time users check for updates. this line seems to be the problem:

electron-builder/packages/electron-updater/src/MacUpdater.ts

Line 123 in 3b03f27

copyFileSync(event.downloadedFile, cachedUpdateFile)

[mmaietta]

Great find in identifying the root cause. Looks like it's non-blocking of the update due to the try-catch, but definitely something that warrants further investigation.

electron-builder/packages/electron-updater/src/MacUpdater.ts

Lines 122 to 127 in 3b03f27

	try {
	copyFileSync(event.downloadedFile, cachedUpdateFile)
	} catch (error: any) {
	this._logger.error(`Unable to copy file for caching: ${error.message}`)
	}
	return this.updateDownloaded(zipFileInfo, event)

The var is set on this line.

electron-builder/packages/electron-updater/src/MacUpdater.ts

Line 104 in 3b03f27

cachedUpdateFile = path.join(this.downloadedUpdateHelper!.cacheDir, CURRENT_MAC_APP_ZIP_FILE_NAME)

I'll continue diving into this, but curious on @beyondkmp's thoughts here? Why would this not be getting executed? The cachedUpdateFile is an empty string

electron-builder/packages/electron-updater/src/MacUpdater.ts

Line 104 in 3b03f27

cachedUpdateFile = path.join(this.downloadedUpdateHelper!.cacheDir, CURRENT_MAC_APP_ZIP_FILE_NAME)

[MelonCode]

hey, any updates on this?

[beyondkmp]

@mmaietta

electron-builder/packages/electron-updater/src/AppUpdater.ts

Lines 698 to 702 in 3b03f27

	const cachedUpdateFile = await downloadedUpdateHelper.validateDownloadedPath(updateFile, updateInfo, fileInfo, log)
	if (cachedUpdateFile != null) {
	updateFile = cachedUpdateFile
	return await done(false)
	}

The problem likely lies here. If cachedUpdateFile already exists, the task function won't run; instead, the done function will be executed directly.

[mmaietta]

Released in 25.1.7, please feel free to give it a shot!