extraMetadata with underscores are not carried

[mauricioszabo]

• Electron-Builder Version: 23.2.0

• Node Version: v14.17.1

• Electron Version: 12.2.3

• Electron Type (current, beta, nightly): current (old)

• Target: Linux

I need to generate a package.json with some metadata. These metadata comes in the form or _something, and also are dynamically generated on the build process. What I ended up doing is generating the metadata during the build process, and then injecting on config.extraMetadata (I'm using electron-builder programatically).

The trouble is that if a metadata starts with underscore, it is not carried through. For example, this config works (metadata gets carried through):

options = {
  "appId": "my.app.id",
  "npmRebuild": false,
  "linux": {
    "icon": "my/icon.png",
    "category": "Development",
    "synopsis": "...",
    "target": [
      {
        "target": "appimage",
        "arch": "x64"
      },
    ]
  },
  "extraMetadata": {
    "something": "It's Something"
  }
}

But if I do change "something" to "_something", it is not added to package.json

[mauricioszabo]

So the removal is indeed happening: https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/fileTransformer.ts#L86

Why exactly this line need to exist? Is there a way I can bypass this? I actually need these elements on my release package.json...

[mauricioszabo]

Actually, now that I see the code, it seems that there's WAY MORE things being removed than I actually want. So can we add a flag to configure what exactly is going to be removed?

[meadowsys]

a better option for this might be to add a config option to set a filter function or regex, and i suppose it can be default to the under score thing, but then it would actually be removable and significantly more configurable than nothing or even just a toggle

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.