Update loop in windows

[philipgiuliani]

Hi! I have no idea where i should report it, so i start here with the hope that somebody can help.

I have packaged my windows app with electron builder and i'm using Squirrel.Windows for auto-updates. I've put everything from the release to the FTP and set the URL properly. But now when I start the windows app its in an update loop. It downloads the 1.0.0 every time again.

Does someone has an idea how it happened?

859E5121E95B411FA2107DF3A59E3880D4E9EA0B myapp-1.0.0-ia32-full.nupkg 45302165

Main app index.js (i ommited unreleated code)

if (require("electron-squirrel-startup")) {
    return;
}

app.on('ready', function() {
    // create new browserwindow

    // search for updates
    const updateFeed = os == "darwin" ? "https://HOST/updates/latest" : "https://HOST/releases/win32";

    const autoUpdater = require('auto-updater');
    autoUpdater.on("update-downloaded", function() {
        autoUpdater.quitAndInstall();
    });

    autoUpdater.setFeedURL(updateFeed + '?v=' + app.getVersion());
    autoUpdater.checkForUpdates();
});

I am building the windows distribution with OSX (Vine) with the following command: build --platform win32 --arch ia32

OSX is working fine.

[jbleuzen]

You should show your code that handle auto-update...
Without that, it's pretty hard to help.

[philipgiuliani]

Sorry, i was currently editing my post, pressed publish accidently.

[develar]

Side note: Don't call autoUpdater.quitAndInstall on "update-downloaded". You should quit only if user click "Ok, quit and install. But better solution is — just show notification — https://github.com/develar/onshape-desktop-shell/blob/master/src/AppUpdater.ts#L24

Please ensure that your updated app has greater version number.

[philipgiuliani]

@develar Thanks, yes i've not implemented it correctly yet, just want to get it running first :/ And thanks for the code snippet!

NGINX access.log after installing and starting the application

[26/Apr/2016:08:50:33 +0200] "GET /downloader/releases/win32/RELEASES?v=1.0.0&id=youtv&localVersion=1.0.0&arch=amd64 HTTP/1.1" 200 91
[26/Apr/2016:08:50:49 +0200] "GET /downloader/releases/win32/youtv-downloader-1.0.0-ia32-full.nupkg HTTP/1.1" 200 45302165
[26/Apr/2016:08:50:49 +0200] "GET /downloader/releases/win32/RELEASES?v=1.0.0&id=youtv&localVersion=1.0.0&arch=amd64 HTTP/1.1" 200 91
[26/Apr/2016:08:51:27 +0200] "GET /downloader/releases/win32/youtv-downloader-1.0.0-ia32-full.nupkg HTTP/1.1" 200 19496705

[develar]

Please see electron/electron#5057

Do you code sign your app?

[philipgiuliani]

Thanks for the link.
No, im not code signing the windows app at the moment. Could it prevent the issue?

[develar]

Could it prevent the issue?

No, it can be a reason of issue.

[philipgiuliani]

Code signing didn't help.

What's happening:

1. App starts
2. Server receives requests to RELEASES and downloads the -full.nupkg two times (auto-updater-win.js downloads updates twice when available. electron/electron#5057)
3. After download the client restarts (autoUpdater.quitAndInstall())
4. It starts again from 1

[philipgiuliani]

I found the issue. I think its a bug in Squirrel.Windows.

I have always uploaded the ia32 version and not the 64bit version. I installed the 32 bit version on a 64bit PC and got into this loop issue. After uploading the 64bit RELEASES + nupkg it worked fine.

[develar]

@philipgiuliani It is your issue due to lack of documentation. Please see #190 (comment) Your update server must serve RELEASES-ia32 as RELEASES on 32-bit update request.

[develar]

Reopened — must be documented.

[philipgiuliani]

When i generated 32 bit version it generates a RELEASES + RELEASES-ia32. I uploaded both and the content seemed the same. The app fetched the RELEASES file (from logs) and downloaded the app-ia32.nupkg. But looping. So the file was actually present. Thanks for your help.

[develar]

The app fetched the RELEASES file

It is an issue in all known update servers. You must send RELEASES-ia32 if RELEASES requested for 32-bit version. See, for example, issue GitbookIO/nuts#32 — nuts server just doesn't support 32-bit releases.

I suggest to distribute only 64-bit versions (forget 32-bit). Or you must fix your update server to support both 32 and 64 bit releases.

But looping.

I see &arch=amd64 in your URL. Are your sure that proper file is returned (i.e. 64-bit version)?

And please, as an easy solution — "I suggest to distribute only 64-bit versions (forget 32-bit)." :)