Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading spinner (loadingGif) to electron-winstaller-fixed options #292

Closed
atietje opened this issue Apr 5, 2016 · 1 comment · May be fixed by qcif/data-curator#563
Closed

Add loading spinner (loadingGif) to electron-winstaller-fixed options #292

atietje opened this issue Apr 5, 2016 · 1 comment · May be fixed by qcif/data-curator#563
Assignees

Comments

@atietje
Copy link

atietje commented Apr 5, 2016

createWindowsInstaller allows to specify a file that will be used instead of the default loading spinner. This option is not used in WinPackager.packageInDistributableFormat.

I suggest to add loadingGif: this.metadata.loadingGif to the options in function packageInDistributableFormat and add the path to the development package.json like
{ "build": {"loadingGif": "./build/install-spinner.gif"} }

@develar
Copy link
Member

develar commented Apr 5, 2016

suggest to add loadingGif: this.metadata.loadingGif to the options

This option should be listed not in the metadata root ., but in the build.win. It is supported already. See https://github.com/electron-userland/electron-builder/blob/master/docs/options.md

add the path to the development package.json like

Yep! Definitely should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants