Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifactName is not work as expected. #2258

Closed
miaulightouch opened this issue Nov 2, 2017 · 4 comments
Closed

artifactName is not work as expected. #2258

miaulightouch opened this issue Nov 2, 2017 · 4 comments

Comments

@miaulightouch
Copy link

  • Version: 19.43.3
  • Target: linux/win

here's my config:

    "win": {
      "artifactName": "${productName}-${version}-${os}-${arch}.${ext}",
      "target": [{
        "target": "zip",
        "arch": ["x64", "ia32"]
      }]
    },
    "linux": {
      "artifactName": "${productName}-${version}-${os}-${arch}.${ext}",
      "target": [{
        "target": "AppImage",
        "arch": ["x64", "ia32"]
      }]
    }

but CI (AppVeyor/Travis) generated filename is

MasterVyrn-0.2.0-linux-i386.AppImage
MasterVyrn-0.2.0-linux.AppImage        (error: no arch)
mastervyrn-0.2.0-ia32-win.zip          (error: pattern order wrong)
mastervyrn-0.2.0-win.zip               (error: no arch)
@develar
Copy link
Member

develar commented Nov 2, 2017

BTW, for Windows consider to use portable.

@develar
Copy link
Member

develar commented Nov 3, 2017

You can also specify artifactName in the build, no need to repeat in the win/linux

develar added a commit to develar/electron-builder that referenced this issue Nov 3, 2017
develar added a commit to develar/electron-builder that referenced this issue Nov 3, 2017
@develar develar closed this as completed in ba999af Nov 3, 2017
@miaulightouch
Copy link
Author

yes, I know, I just must ensure artifactName work properly

@develar
Copy link
Member

develar commented Nov 4, 2017

Fixed in 19.44.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants