feat: support completely custom AppxManifest.xml

electron-userland · Oct 17, 2024 · b99a430 · b99a430
1 parent 74d98d8
commit b99a430
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/packages/app-builder-lib/scheme.json b/packages/app-builder-lib/scheme.json
@@ -183,6 +183,13 @@
           "description": "Relative path to custom extensions xml to be included in an `appmanifest.xml`.",
           "type": "string"
         },
+        "customManifestPath": {
+          "description": "Path to custom AppxManifest.xml",
+          "type": [
+            "null",
+            "string"
+          ]
+        },
         "displayName": {
           "description": "A friendly name that can be displayed to users. Corresponds to [Properties.DisplayName](https://msdn.microsoft.com/en-us/library/windows/apps/br211432.aspx).\nDefaults to the application product name.",
           "type": [

diff --git a/packages/app-builder-lib/src/options/AppXOptions.ts b/packages/app-builder-lib/src/options/AppXOptions.ts
@@ -51,6 +51,11 @@ export interface AppXOptions extends TargetSpecificOptions {
    */
   readonly customExtensionsPath?: string
 
+    /**
+   * Path to custom `AppxManifest.xml`.
+   */
+  readonly customManifestPath?: string
+
   /**
    * Whether to overlay the app's name on top of tile images on the Start screen. Defaults to `false`. (https://docs.microsoft.com/en-us/uwp/schemas/appxpackage/uapmanifestschema/element-uap-shownameontiles) in the dependencies.
    * @default false

diff --git a/packages/app-builder-lib/src/targets/AppxTarget.ts b/packages/app-builder-lib/src/targets/AppxTarget.ts
@@ -98,8 +98,13 @@ export default class AppXTarget extends Target {
     const assetInfo = await AppXTarget.computeUserAssets(vm, vendorPath, userAssetDir)
     const userAssets = assetInfo.userAssets
 
-    const manifestFile = stageDir.getTempFile("AppxManifest.xml")
-    await this.writeManifest(manifestFile, arch, await this.computePublisherName(), userAssets)
+    const manifestFile = this.options.customManifestPath || stageDir.getTempFile("AppxManifest.xml")
+    if (this.options.customManifestPath) {
+      log.info({ reason: "Custom manifest path provided" }, "Manifest writing skipped")
+    } else {
+      await this.writeManifest(manifestFile, arch, await this.computePublisherName(), userAssets)
+    }
+
     await packager.info.callAppxManifestCreated(manifestFile)
     mappingList.push(assetInfo.mappings)
     mappingList.push([`"${vm.toVmFile(manifestFile)}" "AppxManifest.xml"`])