fix: retry renaming update file when EBUSY error occurs due to file lock

electron-userland · Aug 30, 2024 · b6b99c5 · b6b99c5
1 parent 977acaf
commit b6b99c5
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/packages/electron-updater/package.json b/packages/electron-updater/package.json
@@ -16,6 +16,7 @@
     "out"
   ],
   "dependencies": {
+    "builder-util": "workspace:*",
     "builder-util-runtime": "workspace:*",
     "fs-extra": "^10.1.0",
     "js-yaml": "^4.1.0",

diff --git a/packages/electron-updater/src/AppUpdater.ts b/packages/electron-updater/src/AppUpdater.ts
@@ -1,3 +1,4 @@
+import { retry } from "builder-util"
 import {
   AllPublishOptions,
   asArray,
@@ -712,7 +713,14 @@ export abstract class AppUpdater extends (EventEmitter as new () => TypedEmitter
     const tempUpdateFile = await createTempUpdateFile(`temp-${updateFileName}`, cacheDir, log)
     try {
       await taskOptions.task(tempUpdateFile, downloadOptions, packageFile, removeFileIfAny)
-      await rename(tempUpdateFile, updateFile)
+      await retry(
+        () => rename(tempUpdateFile, updateFile),
+        60,
+        500,
+        0,
+        0,
+        error => error instanceof Error && /^EBUSY:/.test(error.message)
+      )
     } catch (e: any) {
       await removeFileIfAny()
 

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml