fix(electron-updater): downloading builds(updates) more than once eve…

…n if downloaded already Close #3007, Close #3003
electron-userland · Jun 24, 2018 · 6500b35 · 6500b35
1 parent 0cdb1c4
commit 6500b35
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/electron-updater/src/DownloadedUpdateHelper.ts b/packages/electron-updater/src/DownloadedUpdateHelper.ts
@@ -25,10 +25,10 @@ export class DownloadedUpdateHelper {
   }
 
   async validateDownloadedPath(updateFile: string, versionInfo: UpdateInfo, fileInfo: ResolvedUpdateFileInfo, logger: Logger): Promise<boolean> {
-    if (this.versionInfo != null && this.file === updateFile) {
+    if (this.versionInfo != null && this.file === updateFile && this.fileInfo != null) {
       // update has already been downloaded from this running instance
       // check here only existence, not checksum
-      return isEqual(this.versionInfo, versionInfo) && isEqual(this.fileInfo, fileInfo) && (await pathExists(updateFile))
+      return isEqual(this.versionInfo, versionInfo) && isEqual(this.fileInfo.info, fileInfo.info) && (await pathExists(updateFile))
     }
 
     // update has already been downloaded from some previous app launch