archetype-react-app: [major] turn off NodeSourcePlugin for prod build

packages/electrode-archetype-react-app-dev/config/webpack/partial/index.js

@@ -11,6 +11,7 @@ const assert = require("assert");
 const orders = [
   "_base-options",
   "_entry",
+  "_node",
   "_output",
   "_resolve",
   "_resolve-loader",
@@ -39,7 +40,8 @@ const orders = [
   "_hot",
   "_html-reporter",
   "_simple-progress",
-  "_sourcemaps-inline"
+  "_sourcemaps-inline",
+  "_node"
 ];
 
 const files = Fs.readdirSync(__dirname)

packages/electrode-archetype-react-app-dev/config/webpack/partial/node.js

@@ -0,0 +1,32 @@
+"use strict";
+
+const archetype = require("electrode-archetype-react-app/config/archetype");
+const webpack = require("webpack");
+const FunctionModulePlugin = require("webpack/lib/FunctionModulePlugin");
+const logger = require("electrode-archetype-react-app/lib/logger");
+
+module.exports = function(options) {
+  const config = options.currentConfig;
+
+  if (
+    process.env.NODE_ENV === "production" &&
+    config.target === undefined &&
+    archetype.webpack.enableNodeSourcePlugin !== true
+  ) {
+    logger.info("Disabling NodeSourcePlugin for production");
+    // disable NodeSourcePlugin by setting a custom target, and then apply the
+    // plugins the original web target would've applied.
+    // will be much easier once webapck with node: false option is released
+    const output = config.output;
+    config.target = () => undefined;
+    config.plugins = [
+      new webpack.JsonpTemplatePlugin(output),
+      new FunctionModulePlugin(output),
+      new webpack.LoaderTargetPlugin("web")
+    ].concat(config.plugins);
+  } else {
+    logger.info("Not disabling NodeSourcePlugin.  NODE_ENV:", process.env.NODE_ENV);
+  }
+
+  return {};
+};

packages/electrode-archetype-react-app-dev/config/webpack/profile.base.js

@@ -14,7 +14,8 @@ const profile = {
     _images: { order: 2300 },
     _stats: { order: 2400 },
     _isomorphic: { order: 2500 },
-    _pwa: { order: 2600 }
+    _pwa: { order: 2600 },
+    _node: { order: 30000 }
   }
 };
 

samples/universal-react-node/src/client/components/record-form.jsx

@@ -1,6 +1,4 @@
 import React from "react";
-import "es6-promise";
-import "isomorphic-fetch";
 
 const HTTP_BAD_REQUEST = 400;
 const HTTP_OK = 200;

samples/universal-react-node/src/client/components/record-store.jsx

@@ -1,6 +1,4 @@
 import React from "react";
-import "es6-promise";
-import "isomorphic-fetch";
 import RecordForm from "./record-form";
 
 const HTTP_BAD_REQUEST = 400;

samples/universal-react-node/src/client/middleware.js

@@ -1,5 +1,3 @@
-import "es6-promise";
-import "isomorphic-fetch";
 const HTTP_BAD_REQUEST = 400;
 const HTTP_OK = 200;
 let token;