Skip to content

Commit

Permalink
chore: changelogs (#1980)
Browse files Browse the repository at this point in the history
* chore: @xarc/opt-karma dependency upgrades

* chore: contribution guideline doc minor command update

* chore: add rush change verify to build and fail if no change files

* chore: add rush change verify to build and fail if no change files

* chore: disable back  rush change verify
  • Loading branch information
arunvishnun authored Jul 18, 2023
1 parent ef72b83 commit 3c36787
Show file tree
Hide file tree
Showing 8 changed files with 776 additions and 756 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,18 @@ jobs:

steps:
- uses: actions/checkout@v3

# with:
# fetch-depth: 0

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

# TODO: enable `rush change -v` after rush migration is completed.
# - name: Verify Change Logs
# run: node common/scripts/install-run-rush.js change --verify --target-branch upstream/master
# - name: Verify Change files and fail build if not available
# run: node common/scripts/install-run-rush.js change --verify

- name: Install
run: node common/scripts/install-run-rush.js install

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Publishing is a three step process. When its time to publish packages (as per re
- Review the CHANGELOG.md updates at this point

#### **2. Publish Packages**
- Run `rush publish --include-all --publish`
- Run `rush publish --include-all --publish --apply`
- This will publish all the public packages that have version increased.
- Push the changes as PR to get the `CHANGELOG.md` updated to `master`.

Expand Down

This file was deleted.

Loading

0 comments on commit 3c36787

Please sign in to comment.