Migrate other graphs to React + deprecate LineGraph component #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
fbarl/1681-migrate-line-graph
branch
from
873e526 to
c57d496
Compare
Closed
fbarl
changed the title
fbarl
force-pushed
the
fbarl/1681-migrate-line-graph
branch
2 times, most recently
from
7270c60 to
bac79d3
Compare
fbarl
changed the title
fbarl
changed the title
corradio
reviewed
Mar 2, 2020
fbarl
force-pushed
the
fbarl/1681-migrate-line-graph
branch
from
548ef41 to
f6f7a00
Compare
corradio
approved these changes
Mar 2, 2020
fbarl
force-pushed
the
fbarl/1681-migrate-line-graph
branch
from
f6f7a00 to
8809170
Compare
con-cat
pushed a commit
to con-cat/electricitymap-contrib
that referenced
this pull request
May 18, 2021
…icitymaps#2254) * Introduced CountryHistoryCarbonGraph wrapper component around AreaGraph * Introduced CountryHistoryPricesGraph wrapper component around AreaGraph * Got rid of now unused LineGraph component * Removed renderOpenTooltips * Better centering of y-axis label * Parametrize AreaGraph height * Extract graph mouse action handlers into helpers/history.js * Introduce PRICES_GRAPH_LAYER_KEY and CARBON_GRAPH_LAYER_KEY constants * Better handling of graph background mouse events * Graph background hover over single layer graphs shows tooltip * Fixed hover events in mobile mode * Add more prop explanations * Rename focusFill -> markerFill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1681 (comment).
Tested
360px) as well as desktopChanges
LineGraphcomponent in favor of the extendedAreaGraphcomponentCountryHistoryCarbonGraphandCountryHistoryPricesGraphinto no-prop wrappers aroundAreaGraphmain.jsa bit more explicithistory.jshelper fileAreaGraph:layerStroke- the prices graph had a light gray stroke, thought we might want to keep itfocusFill- the prices graph has a gray fill but the hover focus circle has a shade of orange as a fill, thought we might want to keep itheight- as the heights of all 3 graphs are currently different