Debug and fix stuck test in PR #3602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'should decode data columns with columnMapper' test was hanging because the mock response didn't include an up-to-date control message. Without this message, the ShapeStream kept requesting more data in an infinite loop that blocked the event loop. This fix adds: 1. An up-to-date control message to the mock response body 2. The 'electric-up-to-date' header to signal completion This ensures the stream properly terminates after processing the initial data.
Add 30s default timeout in vitest.config.ts so any test that gets stuck in an infinite loop will fail fast with a clear timeout error instead of blocking CI indefinitely.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3602 +/- ##
===========================================
+ Coverage 61.97% 75.77% +13.79%
===========================================
Files 40 51 +11
Lines 1557 2753 +1196
Branches 104 406 +302
===========================================
+ Hits 965 2086 +1121
- Misses 591 665 +74
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
commit: |
Member
|
I've cancelled the stuck job after I noticed it had been running for 1 hour this morning. Still the same OOM error from running the test. Do you think we have a memory leak somewhere? |
Contributor
Author
|
@alco looks like it's working now — the problem was a infinite loop caused by using Promise.resolve() (resolves inside a microtask before timers run) so test timeouts didn't run. |
KyleAMathews
deleted the
claude/debug-stuck-test-017crykW9sUHjBJHkstqzHPW
branch
This was referenced Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.