ci: Build a Docker image for sync-service to reuse in CI workflows #3594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3594 +/- ##
=======================================
Coverage 88.13% 88.13%
=======================================
Files 18 18
Lines 1635 1635
Branches 411 407 -4
=======================================
Hits 1441 1441
Misses 192 192
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alco
changed the title
alco
force-pushed
the
alco/ci-sync-service-docker-image
branch
from
88ad47f to
91b6337
Compare
alco
changed the base branch from
main
to
alco/ci-preconfigured-postgres-image
alco
force-pushed
the
alco/ci-sync-service-docker-image
branch
8 times, most recently
from
2cc21be to
57e1dd1
Compare
alco
force-pushed
the
alco/ci-preconfigured-postgres-image
branch
from
c05f543 to
9229b8a
Compare
10 tasks
alco
added a commit
that referenced
this pull request
Dec 15, 2025
Base automatically changed from
alco/ci-preconfigured-postgres-image
to
main
December 15, 2025 15:54
alco
added a commit
that referenced
this pull request
Dec 15, 2025
…use in CI workflows (#3588) This serves multiple goals: - avoid repeating configuration code between CI workflows - get rid of the need to run `psql` or `docker exec` commands in addition to defining Postgres as a service in those CI workflows that need it. See #3600. - #3594 packages up sync-service as a Docker image for use in CI. However, it cannot be easily started as a service if the postgres service needs to be configured afterwards In other words, this together with building a Docker image for sync service to use in CI workflows from the other PR helps avoid redoing some of the build steps between different CI workflows.
alco
force-pushed
the
alco/ci-sync-service-docker-image
branch
3 times, most recently
from
d7b8cbc to
0cba86a
Compare
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alco
force-pushed
the
alco/ci-sync-service-docker-image
branch
6 times, most recently
from
d5acd25 to
4d08030
Compare
alco
force-pushed
the
alco/ci-sync-service-docker-image
branch
from
4d08030 to
046776c
Compare
alco
force-pushed
the
alco/ci-sync-service-docker-image
branch
2 times, most recently
from
c8a3975 to
a7af5e1
Compare
alco
force-pushed
the
alco/ci-sync-service-docker-image
branch
from
a7af5e1 to
143b44e
Compare
Member
Author
|
I've finished doing CI updates for this PR but there are three TS tests that keep failing consistently. Currently not sure what's causing that. |
I've already missed the Dockerfile itself by trying to be overly specific with the paths touched by a commit. Better be safe and take all the entire contents of the package directory into account when deciding on rebuilding the Docker image. After all, we have the Docker build cache to avoid unnecessary rebuilds.
…r in CI This solves the discrepancy between running Electric from source and via docker compose.
Member
Author
Figured it out: had to include |
msfstef
approved these changes
Dec 16, 2025
Contributor
msfstef
left a comment
msfstef
left a comment
There was a problem hiding this comment.
Interesting! Is this faster than running it from the Elixir source?
Member
Author
|
@msfstef I think performance difference will be negligible. What this approach gives us is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating caching and compilation logic for Electric in TS tests, build a Docker image from sync-service's source code and run it as a Docker container.
In a followup PR I'm going to also use the sync-service Docker container when running Lux integration tests.
One positive outcome from this is that we no longer need a dummy workflow to test that sync-service works when running in a Docker container. It is now implicitly verified by running it in a Docker container in existing workflows.