Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(website) Add throughput benchmarks #2182

Merged
merged 4 commits into from
Dec 18, 2024
Merged

(website) Add throughput benchmarks #2182

merged 4 commits into from
Dec 18, 2024

Conversation

robacourt
Copy link
Contributor

No description provided.

@robacourt robacourt marked this pull request as ready for review December 18, 2024 12:40
@netlify Netlify
Copy link

netlify bot commented Dec 18, 2024 •
edited
Loading

✅ Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 2454497
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/6762ce64bcc9af0008f1ec53
😎 Deploy Preview https://deploy-preview-2182--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thruflo
thruflo requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@thruflo thruflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

Also, I'm loving the new dark theme for the images :)

website/docs/reference/benchmarks.md
</a>
</figure>

This benchmark measures how long each write takes to process with a varying number of shapes. Each shape in this benchmark
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this description needs a clearer statement of what an optimised where clause is vs a non-optimised clause. You could even call this out to an info panel e.g.:

> [!Tip] Optimised where clauses
> ... describe here ...

From the current description I read (towards the end of the para) that I can think of it as "analogous to having an index on the field" but really I would like to know what the term means when you're first using it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Done.

@robacourt robacourt merged commit 7a836f0 into main Dec 18, 2024
6 checks passed
@robacourt robacourt deleted the rob/add-throughput-benchmarks branch December 18, 2024 13:37
@robacourt robacourt mentioned this pull request Dec 18, 2024
Merged
robacourt added a commit that referenced this pull request Dec 19, 2024
@robacourt @thruflo
(website) Update shape docs to include details of where clause optimi…
88c77cd 
…sation (#2185)

Following on from #2182 on @thruflo 's suggestion, this PR add's where
clause optimisation documentation to the main docs and links to it from
various places. This includes what types of where clauses are optimised.

---------

Co-authored-by: James Arthur <thruflo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thruflo thruflo thruflo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robacourt @thruflo