fix(elixir-client): link request & monitor so client never stalls #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacourt
approved these changes
Dec 4, 2024
magnetised
requested changes
Dec 4, 2024
| @@ -37,6 +37,10 @@ defmodule Electric.Client.Fetch.Monitor do | |||
| def wait(ref) do | |||
| receive do | |||
| {:response, ^ref, response} -> response | |||
| after | |||
| 60_000 -> | |||
There was a problem hiding this comment.
I worry about a global timeout because the connection may be receiving a large chunk of data successfully, but slowly. I think with the process linking we should handle any errors and I'd prefer timeouts to be handled by the HTTP client, which is aware of what's happening on the connection (e.g. the difference between a slow download and a broken, unresponsive, connection)
There was a problem hiding this comment.
Ok, sounds good. We do know that the response process died, so that should be alright
icehaunter
force-pushed
the
ilia/fix-stuck-elixir-client
branch
from
033c216 to
8cf8cbb
Compare
icehaunter
force-pushed
the
ilia/fix-stuck-elixir-client
branch
from
8cf8cbb to
b3a8434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.