Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accept URI structs as endpoint/base_url options #2015

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat: accept URI structs as endpoint/base_url options #2015

merged 1 commit into from
Nov 21, 2024

Conversation

icehaunter
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 21, 2024

✅ Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 118a968
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/673efb91cc13ac00087d547c
😎 Deploy Preview https://deploy-preview-2015--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

magnetised
magnetised requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@magnetised magnetised left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but can we add a test to prove that it works pls. There's a suite of new/1 tests in client_test.exs

@icehaunter icehaunter force-pushed the ilia/electric-client-uri-structs branch from 118a968 to 917e1c1 Compare November 21, 2024 10:24
@icehaunter icehaunter force-pushed the ilia/electric-client-uri-structs branch from 917e1c1 to b3c4443 Compare November 21, 2024 10:32
magnetised
magnetised approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@magnetised magnetised left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Souper

@icehaunter icehaunter merged commit fed0761 into main Nov 21, 2024
26 checks passed
@icehaunter icehaunter deleted the ilia/electric-client-uri-structs branch November 21, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetised magnetised magnetised approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icehaunter @magnetised