Skip to content

Commit

Permalink
Fix: typescript resolution when building types (#200)
Browse files Browse the repository at this point in the history
Add a base tsconfig build config which includes everything in the
monorepo so packages can resolve each other.

Fix for
https://github.com/electric-sql/electric-next/actions/runs/10101397601/job/27934902207#step:6:6
  • Loading branch information
KyleAMathews authored Jul 26, 2024
1 parent 39fd641 commit 223a76a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
3 changes: 2 additions & 1 deletion packages/react-hooks/tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
/* Visit https://aka.ms/tsconfig.json to read more about this file */

Expand Down Expand Up @@ -28,7 +29,7 @@
/* Modules */
"module": "ESNext" /* Specify what module code is generated. */,
// "rootDir": "./", /* Specify the root folder within your source files. */
"moduleResolution": "Bundler", /* Specify how TypeScript looks up a file from a given module specifier. */
"moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
// "baseUrl": "./", /* Specify the base directory to resolve non-relative module names. */
// "paths": {}, /* Specify a set of entries that re-map imports to additional lookup locations. */
// "rootDirs": [], /* Allow multiple folders to be treated as one when resolving modules. */
Expand Down
3 changes: 2 additions & 1 deletion packages/typescript-client/tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"extends": "../../tsconfig.build.json",
"compilerOptions": {
/* Visit https://aka.ms/tsconfig.json to read more about this file */

Expand Down Expand Up @@ -28,7 +29,7 @@
/* Modules */
"module": "ESNext" /* Specify what module code is generated. */,
// "rootDir": "./", /* Specify the root folder within your source files. */
"moduleResolution": "Bundler", /* Specify how TypeScript looks up a file from a given module specifier. */
"moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
// "baseUrl": "./", /* Specify the base directory to resolve non-relative module names. */
// "paths": {}, /* Specify a set of entries that re-map imports to additional lookup locations. */
// "rootDirs": [], /* Allow multiple folders to be treated as one when resolving modules. */
Expand Down
7 changes: 7 additions & 0 deletions tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"compilerOptions": {
"incremental": false,
"noEmit": false
},
"include": ["**/*", ".*.js"]
}

0 comments on commit 223a76a

Please sign in to comment.