Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string referrer/source to UI #185

Closed
wants to merge 4 commits into from
Closed

Add string referrer/source to UI #185

wants to merge 4 commits into from

Conversation

BetaHuhn
Copy link
Contributor

@BetaHuhn BetaHuhn commented Nov 4, 2020

This PR compliments #173 and adds support for the source feature to Ackee's UI.

Solves #169

@vercel
Copy link

vercel bot commented Nov 4, 2020

@BetaHuhn is attempting to deploy a commit to a Personal Account owned by Tobias Reich on Vercel.

@electerious first needs to authorize it.

@coveralls
Copy link

coveralls commented Nov 4, 2020

Pull Request Test Coverage Report for Build 703

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.278%

Totals Coverage Status
Change from base Build 687: 0.0%
Covered Lines: 460
Relevant Lines: 829

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 4, 2020

Pull Request Test Coverage Report for Build 705

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.278%

Totals Coverage Status
Change from base Build 687: 0.0%
Covered Lines: 460
Relevant Lines: 829

💛 - Coveralls

@vercel
Copy link

vercel bot commented Nov 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/electerious/ackee/as4g7d0zh
✅ Preview: Failed

@BetaHuhn BetaHuhn mentioned this pull request Dec 12, 2020
@electerious electerious deleted the branch electerious:feature/source December 31, 2020 10:02
electerious added a commit that referenced this pull request Dec 31, 2020
electerious added a commit that referenced this pull request Dec 31, 2020
electerious added a commit that referenced this pull request Dec 31, 2020
@electerious
Copy link
Owner

Sources are now a part of v3. I've also added a ReferrerType so it's possible to display referrers with and without sources.

electerious added a commit that referenced this pull request Dec 31, 2020
electerious added a commit that referenced this pull request Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants