[Bug](bitmap-filter) fix wrong type cast on BitmapFilterColumnPredica…

…te::evaluate (apache#43877) ### What problem does this PR solve? fix wrong type cast on BitmapFilterColumnPredicate::evaluate ![img_v3_02gj_453c524a-5330-4180-9169-9760edcd74eg](https://github.com/user-attachments/assets/2b8e1fa7-2568-4cd8-bd00-aa58d107796b)
eldenmoon · Nov 13, 2024 · 7b9bee0 · 7b9bee0
1 parent 5a4f7c6
commit 7b9bee0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/be/src/olap/bitmap_filter_predicate.h b/be/src/olap/bitmap_filter_predicate.h
@@ -40,7 +40,7 @@ class BitmapFilterColumnPredicate : public ColumnPredicate {
                                 const std::shared_ptr<BitmapFilterFuncBase>& filter, int)
             : ColumnPredicate(column_id),
               _filter(filter),
-              _specific_filter(static_cast<SpecificFilter*>(_filter.get())) {}
+              _specific_filter(assert_cast<SpecificFilter*>(_filter.get())) {}
     ~BitmapFilterColumnPredicate() override = default;
 
     PredicateType type() const override { return PredicateType::BITMAP_FILTER; }

diff --git a/be/test/olap/bitmap_filter_column_predicate_test.cpp b/be/test/olap/bitmap_filter_column_predicate_test.cpp
@@ -128,7 +128,7 @@ TEST_F(BitmapFilterColumnPredicateTest, evaluate_column) {
     bitmap_value.add_many(filter_values.data(), filter_values.size());
     filter->insert(&bitmap_value);
 
-    auto column = vectorized::ColumnInt32::create();
+    auto column = vectorized::PredicateColumnType<TYPE_INT>::create();
     column->insert_many_fix_len_data(reinterpret_cast<const char*>(values.data()), values.size());
 
     uint16_t* sel = new uint16_t[column->size()];
@@ -162,7 +162,7 @@ TEST_F(BitmapFilterColumnPredicateTest, evaluate_column_nullable) {
     bitmap_value.add_many(filter_values.data(), filter_values.size());
     filter->insert(&bitmap_value);
 
-    auto column = vectorized::ColumnInt32::create();
+    auto column = vectorized::PredicateColumnType<TYPE_INT>::create();
     column->insert_many_fix_len_data(reinterpret_cast<const char*>(values.data()), values.size());
     auto flag = vectorized::ColumnUInt8::create();
     flag->insert_many_defaults(column->size());