Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mongo functional tests with identified fixes. #4

Merged
merged 5 commits into from
Feb 24, 2020
Merged

Added Mongo functional tests with identified fixes. #4

merged 5 commits into from
Feb 24, 2020

Conversation

iisisrael
Copy link

Functional tests for ODM revealed bug in auth code and token manager result count return. Additional environment configuration also revealed that the BootTest had so far been giving a false positives, as the test environment wasn't actually being changed.

Deprecation messages around php-mock/php-mock-phpunit are not yet resolved in that package, but are so far inconsequential.

@iisisrael
Copy link
Author

iisisrael commented Feb 19, 2020

Also restored the void return in the OAuthListener when the bearer token is not found. This is the expected behavior, and an exception is not necessary. Since no token or response is set on the event as a result of any authentication attempt, Symfony will respond with an AuthenticationCredentialsNotFoundException.

@elchris elchris merged commit 6c7e091 into elchris:symfony-5 Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants