Skip to content

chore: fix Rust 1.86 type inference and update to Rust 1.86 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beanow-at-crabnebula wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: fix Rust 1.86 type inference and update to Rust 1.86 #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e66a5f
chore: fix rust 1.86.0 type inference
beanow-at-crabnebula Apr 8, 2025
59b59a5
chore: update to Rust 1.86
beanow-at-crabnebula Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@1.85.0
uses: dtolnay/rust-toolchain@1.86.0
with:
components: rustfmt
- uses: Swatinem/rust-cache@v2
Expand All @@ -57,7 +57,7 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@1.85.0
uses: dtolnay/rust-toolchain@1.86.0
with:
components: clippy
- uses: Swatinem/rust-cache@v2
Expand All @@ -84,7 +84,7 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@1.85.0
uses: dtolnay/rust-toolchain@1.86.0
- uses: Swatinem/rust-cache@v2
- name: Cache the minio binary
id: cache-minio
Expand Down Expand Up @@ -149,7 +149,7 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@1.85.0
uses: dtolnay/rust-toolchain@1.86.0
with:
targets: x86_64-unknown-linux-musl
- name: Install MUSL deps
Expand All @@ -174,7 +174,7 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@1.85.0
uses: dtolnay/rust-toolchain@1.86.0
- uses: Swatinem/rust-cache@v2
- name: Check documentation
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-crates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@1.85.0
uses: dtolnay/rust-toolchain@1.86.0
- uses: Swatinem/rust-cache@v2
- name: Publish ssstar-testing
uses: actions-rs/cargo@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@1.85.0
uses: dtolnay/rust-toolchain@1.86.0
with:
targets: ${{ matrix.job.target }}
- uses: Swatinem/rust-cache@v2
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# in CI does not and probably never will honor `rust-toolchain`. So if you ever update this Rust version, make sure
# that you also modify the GHA workflows in `.github/workflows/` to use the same version, or some confusing artifacts
# will likely present themselves.
channel = "1.85.0"
channel = "1.86.0"
2 changes: 1 addition & 1 deletion ssstar/src/extract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ impl ExtractFilter {
/// be `foo/bar/baz`
fn matches(&self, path: &Path) -> bool {
match self {
Self::Object { key } => path.to_string_lossy() == key.as_ref(),
Self::Object { key } => path.to_string_lossy() == key.as_str(),
Self::Prefix { prefix } => path.to_string_lossy().starts_with(&**prefix),
Self::Glob { pattern } => {
// To make sure the glob matching behaviors like it does in unix shells, require
Expand Down