-
Notifications
You must be signed in to change notification settings - Fork 0
feat: address metrics improvements #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7af390 to
b2e528a
Compare
maksym-iv-ef
reviewed
Jan 2, 2026
Contributor
maksym-iv-ef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few notes
10 tasks
5e1953b to
ff02856
Compare
svencowart
previously approved these changes
Jan 6, 2026
svencowart
approved these changes
Jan 7, 2026
Contributor
|
In a follow-up PRs we are going to iterate over unifying metrics for the eBPF maps so each eBPF map to have same subset of metrics in order to simplify eBPF map observability |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(metrics): refine metrics naming and organization
Changes
Refactors metrics naming to use consistent subsystem prefixes and standardizes processing latency metric labels. Replaces
EXPORT_LATENCY_SECONDSwith unifiedPROCESSING_LATENCY_SECONDShistogram.Key Changes
ProcessingStageenum: Type-safe labels for processing latency metrics (ebpf_ringbuf_output,producer_output,decorator_output)mermin_ebpf_map_entries→mermin_ebpf_map_entries)EXPORT_LATENCY_SECONDSwithPROCESSING_LATENCY_SECONDSusingdecorator_outputstage labelExportStatus::Attempted: Simplified export status trackingFLOW_PRODUCER_FLOW_SPANS_TOTAL→PROCESSING_TOTALfor clarityType of change
Testing
Proof it works
Checklist
cargo fmtandcargo clippy)Notes
This is a metrics naming refinement that improves consistency and maintainability. The subsystem-based naming makes it easier to understand metric relationships and reduces naming conflicts. The unified processing latency metric provides better observability across the pipeline.