Petstore 2019 #14
Merged
Petstore 2019 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvd-z
approved these changes
Oct 25, 2019
dvd-z
reviewed
Oct 25, 2019
hannah-bulmer
force-pushed
the
petstore-2019
branch
2 times, most recently
from
685606c to
2f317b3
Compare
hannah-bulmer
force-pushed
the
petstore-2019
branch
from
2f317b3 to
00b6cc6
Compare
jhorbulyk
reviewed
Oct 28, 2019
jhorbulyk
approved these changes
Oct 28, 2019
This was referenced Oct 28, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have updated the Petstore component to be compliant with our 2019 coding standards and styles, removed outdated libraries, etc
Fixes following issues:
#12: eslinting
#8: adds enums to metatdata
#7: adds descriptions to actions/triggers
I'm not sure if it's worth noting/doing anything about since this is just a tool for teaching, but the POST /pet endpoint does not actually post anything anywhere, so this action does not actually do anything at all...