Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: remove -e in favor of NODE_ENV #318

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

vigneshshanmugam
Copy link
Member

  • Remove -e flag in favor of NODE_ENV which will behave the same way as the -e flag.
  • Dynamic config still works the same way and we default to development when running suites.

@apmmachine
Copy link

❕ Build Aborted

Either there was a build timeout or someone aborted the build.'}

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: Pull request #318 opened

  • Start Time: 2021-06-24T15:18:56.563+0000

  • Duration: 27 min 1 sec

  • Commit: fc4fe01

Test stats 🧪

Test Results
Failed 0
Passed 110
Skipped 0
Total 110

Trends 🧪

Image of Build Times

Image of Tests

Log output

Expand to view the last 100 lines of log output

[2021-06-24T15:28:07.564Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-06-24T15:28:07.572Z]  > git config core.sparsecheckout # timeout=10
[2021-06-24T15:28:07.576Z]  > git checkout -f fc4fe01d79fb226b54542b0049a7bf83ad85a74e # timeout=15
[2021-06-24T15:28:11.105Z] Commit message: "BREAKING CHANGE: remove -e in favor of NODE_ENV"
[2021-06-24T15:28:11.105Z] Cleaning workspace
[2021-06-24T15:28:11.183Z]  > git --version # timeout=10
[2021-06-24T15:28:11.187Z]  > git --version # 'git version 2.17.1'
[2021-06-24T15:28:11.197Z] fatal: bad object bbed8ab717206e63fa6cc1cef7d35f4a13f717ab
[2021-06-24T15:28:11.107Z]  > git rev-parse --verify HEAD # timeout=10
[2021-06-24T15:28:11.126Z] Resetting working tree
[2021-06-24T15:28:11.126Z]  > git reset --hard # timeout=10
[2021-06-24T15:28:11.147Z]  > git clean -fdx # timeout=10
[2021-06-24T15:28:13.207Z] Running in /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-318/src/github.com/elastic/synthetics
[2021-06-24T15:28:26.999Z] + set +x
[2021-06-24T15:28:26.999Z] => Downloading nvm from git to '/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-318/.nvm'
[2021-06-24T15:28:26.999Z] 
=> Initialized empty Git repository in /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-318/.nvm/.git/
[2021-06-24T15:28:27.567Z] From https://github.com/nvm-sh/nvm
[2021-06-24T15:28:27.567Z]  * [new tag]         v0.37.1    -> v0.37.1
[2021-06-24T15:28:27.567Z] => Compressing and cleaning up git repository
[2021-06-24T15:28:27.567Z] 
[2021-06-24T15:28:27.567Z] => Profile not found. Tried ~/.bashrc, ~/.bash_profile, ~/.zshrc, and ~/.profile.
[2021-06-24T15:28:27.567Z] => Create one of them and run this script again
[2021-06-24T15:28:27.567Z]    OR
[2021-06-24T15:28:27.567Z] => Append the following lines to the correct file yourself:
[2021-06-24T15:28:27.567Z] 
[2021-06-24T15:28:27.567Z] export NVM_DIR="$HOME/.nvm"
[2021-06-24T15:28:27.567Z] [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[2021-06-24T15:28:27.567Z] 
[2021-06-24T15:28:29.474Z] => Close and reopen your terminal to start using nvm or run the following to use it now:
[2021-06-24T15:28:29.474Z] 
[2021-06-24T15:28:29.474Z] export NVM_DIR="$HOME/.nvm"
[2021-06-24T15:28:29.474Z] [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[2021-06-24T15:28:29.474Z] Installing latest LTS version.
[2021-06-24T15:28:29.474Z] v14.17.1 is already installed.
[2021-06-24T15:28:29.732Z] Now using node v14.17.1 (npm v6.14.13)
[2021-06-24T15:28:29.851Z] Running in /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-318/src/github.com/elastic/synthetics
[2021-06-24T15:28:30.164Z] + chmod -R ugo+rw examples
[2021-06-24T15:28:30.191Z] Running in /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-318/src/github.com/elastic/synthetics/__tests__/e2e
[2021-06-24T15:28:30.505Z] + npm run test
[2021-06-24T15:28:30.505Z] 
[2021-06-24T15:28:30.505Z] > e2e-synthetics@ test /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-318/src/github.com/elastic/synthetics/__tests__/e2e
[2021-06-24T15:28:30.505Z] > npm i && npm run setup &&  bash scripts/test.sh
[2021-06-24T15:28:30.505Z] 
[2021-06-24T15:28:33.794Z] added 3 packages from 4 contributors and audited 178 packages in 2.398s
[2021-06-24T15:28:35.700Z] 
[2021-06-24T15:28:35.700Z] 66 packages are looking for funding
[2021-06-24T15:28:35.700Z]   run `npm fund` for details
[2021-06-24T15:28:35.700Z] 
[2021-06-24T15:28:35.700Z] found 1 moderate severity vulnerability
[2021-06-24T15:28:35.700Z]   run `npm audit fix` to fix them, or `npm audit` for details
[2021-06-24T15:28:35.700Z] 
[2021-06-24T15:28:35.700Z] > e2e-synthetics@ setup /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-318/src/github.com/elastic/synthetics/__tests__/e2e
[2021-06-24T15:28:35.700Z] > bash scripts/setup.sh
[2021-06-24T15:28:35.700Z] 
[2021-06-24T15:28:35.958Z] 
[2021-06-24T15:28:35.958Z] Temporary folder
[2021-06-24T15:28:35.958Z] Temporary files will be stored in: ./tmp
[2021-06-24T15:28:35.958Z] 
[2021-06-24T15:28:35.958Z] Starting elasticsearch , kibana and synthetics docker
[2021-06-24T15:28:35.958Z] 
[2021-06-24T15:28:35.958Z] 
[2021-06-24T15:28:35.958Z] Waiting for synthetics docker to start...
[2021-06-24T15:28:35.958Z] Error: No such object: synthetics
[2021-06-24T15:28:45.945Z] Error: No such object: synthetics
[2021-06-24T15:28:58.152Z] Error: No such object: synthetics
[2021-06-24T15:29:06.269Z] Error: No such object: synthetics
[2021-06-24T15:29:16.255Z] Error: No such object: synthetics
[2021-06-24T15:29:26.233Z] Error: No such object: synthetics
[2021-06-24T15:29:38.442Z] ✅ Setup completed successfully. Running e2e tests...
[2021-06-24T15:29:38.442Z] Waiting for Elastic Search  to start
[2021-06-24T15:30:17.335Z] Waiting for Synthetics to send data to ES for test monitor
[2021-06-24T15:45:44.526Z] Cancelling nested steps due to timeout
[2021-06-24T15:45:44.534Z] Sending interrupt signal to process
[2021-06-24T15:45:54.584Z] scripts/test.sh: line 26:  5598 Terminated              SYNTHETICS_JUNIT_FILE='junit.xml' npx @elastic/synthetics uptime.journey.ts --reporter junit
[2021-06-24T15:45:54.585Z] npm ERR! code ELIFECYCLE
[2021-06-24T15:45:54.585Z] npm ERR! errno 143
[2021-06-24T15:45:54.585Z] npm ERR! e2e-synthetics@ test: `npm i && npm run setup &&  bash scripts/test.sh`
[2021-06-24T15:45:54.585Z] npm ERR! Exit status 143
[2021-06-24T15:45:54.585Z] npm ERR! 
[2021-06-24T15:45:54.585Z] npm ERR! Failed at the e2e-synthetics@ test script.
[2021-06-24T15:45:54.585Z] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[2021-06-24T15:45:54.585Z] 
[2021-06-24T15:45:54.585Z] npm ERR! A complete log of this run can be found in:
[2021-06-24T15:45:54.585Z] npm ERR!     /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-318/.npm/_logs/2021-06-24T15_45_49_997Z-debug.log
[2021-06-24T15:45:54.594Z] script returned exit code 143
[2021-06-24T15:45:55.834Z] Post stage
[2021-06-24T15:45:55.869Z] Archiving artifacts
[2021-06-24T15:45:56.024Z] Recording test results
[2021-06-24T15:45:56.133Z] None of the test reports contained any result
[2021-06-24T15:45:56.143Z] [Checks API] No suitable checks publisher found.
[2021-06-24T15:45:56.400Z] Stage "Release" skipped due to earlier failure(s)
[2021-06-24T15:45:56.441Z] Stage "Release" skipped due to earlier failure(s)
[2021-06-24T15:45:56.519Z] Stage "Release" skipped due to earlier failure(s)
[2021-06-24T15:45:56.905Z] Running on Jenkins in /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-318
[2021-06-24T15:45:56.990Z] [INFO] getVaultSecret: Getting secrets
[2021-06-24T15:45:57.036Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-06-24T15:45:57.985Z] + chmod 755 generate-build-data.sh
[2021-06-24T15:45:57.985Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-318/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-318/runs/1 ABORTED 1621150
[2021-06-24T15:45:57.985Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-318/runs/1/steps/?limit=10000 -o steps-info.json
[2021-06-24T15:45:57.985Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-318/runs/1/tests/?status=FAILED -o tests-errors.json

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam vigneshshanmugam merged commit 7902aff into elastic:master Jun 24, 2021
@vigneshshanmugam vigneshshanmugam deleted the remove-e-flag branch June 24, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants