Update to Go 1.22 and update deps #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go mod tidy
andrewkroh
force-pushed
the
update-deps-20240319
branch
from
0b6792a
to
15b8f06
Compare
andrewkroh
force-pushed
the
update-deps-20240319
branch
from
b083627
to
d80e1cb
Compare
aleksmaus
approved these changes
Mar 20, 2024
efd6
reviewed
Mar 20, 2024
Comment on lines
+4
to
+5
| GOIMPORTS := go run golang.org/x/tools/cmd/goimports@latest | ||
| GOLICENSER := go run github.com/elastic/go-licenser@latest |
There was a problem hiding this comment.
Suggest that if @latest are used, the makefile emits the version of the tools during the build.
curl -s https://proxy.golang.org/golang.org/x/tools/@latest | jq '.Version'
curl -s https://proxy.golang.org/github.com/elastic/go-licenser/@latest | jq '.Version'
There was a problem hiding this comment.
I think what you are saying is that we should not use @latest? Based on recent pains, I would agree. Moving toward a more hermetic build would be better despite the increased effort to periodically update versions.
There was a problem hiding this comment.
I would prefer not to have dynamic versions, yes.
There was a problem hiding this comment.
I opened #80 to automate this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Go 1.22.
Update dependencies.
Bind to 127.0.0.1 when testing.
Add dependabot.yml config to keep GH actions updated.
Remove usage of
GO111MODULE=off.Update to https://github.com/updatecli/updatecli-action/releases/tag/v2.56.0.