pkg/httpjson: add minify_json template helper #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper allows nicely formatted JSON to be sent the the client as
single-line JSON text.
rules:
- path: "/static/minify"
methods: ["GET"]
responses:
- status_code: 200
body: |-
{{ minify_json `
{
"key1": "value1",
"key2": "value2"
}
`}}
will respond to requests to /static/minify with {"key1":"value1","key2":"value2"}.
andrewkroh
reviewed
Jan 22, 2024
pkg/httpserver/config.go
Outdated
| @@ -98,3 +100,8 @@ func file(path string) (string, error) { | |||
| } | |||
| return string(b), nil | |||
| } | |||
|
|
|||
| func minify(body string) (string, error) { | |||
| b, err := json.Marshal(json.RawMessage(body)) | |||
There was a problem hiding this comment.
I think we should turn off EscapeHTML as to not have this modifying content outside of ordering and spacing.
There was a problem hiding this comment.
Pity jsonv2 is not here yet.
💚 Build Succeeded
History |
andrewkroh
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper allows nicely formatted JSON to be sent the the client as single-line JSON text.
will respond to requests to /static/minify with
{"key1":"value1","key2":"value2"}.